Comments on: Not about JavaScript

By: josh

josh — Sat, 29 Nov 2008 03:44:05 +0000

Aha! Thank you for the tip – important for doing stuff on other instances than a single post.

By: Otto

Otto — Fri, 28 Nov 2008 18:19:14 +0000

No, is_singular() was correct. It’s a function that returns the variable (much like all the other is_whatever() functions).

is_singular() returns true on single posts, pages, and attachments. This is just slightly different from is_single().

By: Threadbare no longer (Simplish 2.1.4RC) - Simplish

Threadbare no longer (Simplish 2.1.4RC) - Simplish — Thu, 27 Nov 2008 19:36:07 +0000

[...] mentioned in comments on my original mild objection, I’ve been convinced that threaded discussions, new in the upcoming WordPress version 2.7, [...]

By: josh

josh — Thu, 27 Nov 2008 02:10:21 +0000

@Otto: Another note/a question: You wrote above: if ( get_option('thread_comments') && is_singular() ) wp_enqueue_script( 'comment-reply' ); …where I think you meant is_single(). is_singular seems to be a variable. Do you know something I don't, or was that a typo?

By: josh

josh — Thu, 27 Nov 2008 02:05:36 +0000

@Otto: I decided when I typed the @Otto to the left that I was convinced. Let’s have comment threads!

To wit, I’ll post a new post on this blog in a few minutes with my quick alpha-quality paste-together of threaded comments in Simplish. Your tutorial (linked above) was so helpful that you probably deserve an author line in the NOTICE file. :-)

By: Otto

Otto — Sat, 22 Nov 2008 19:18:38 +0000

I see your point with the plugin aspect, and normally I agree with you, but comment threading is something that really needed to be standardized. There were already too many ways of doing it, and for simple SEO purposes, it’s important for the methodology to be the same, or at least similar, amongst all sites. When the search engines can optimize to a particular layout, then their results become far more useful and more likely to drive traffic to your site.

Also, the threading does work without javascript. It’s just not as nice and easy to use, requiring an extra and somewhat pointless page-load.

By: josh

josh — Thu, 20 Nov 2008 09:41:25 +0000

@demetris: It’s in:

Author: Demetris < > 2008-11-19 12:12:34 Committer: Josh Wood 2008-11-19 15:12:57 Parent: 151ef711e85a5da02969a43cbb1bf6a3f1ff2159 (bumped to new RC version) Branch: master Follows: 2.1.2 Precedes:

add optimized background header image. Thanks Demetris @ op111.net.

By: demetris

demetris — Wed, 19 Nov 2008 19:53:10 +0000

Here is the PNG:

http://op111.net/files/img/sp-background-256b.png

:-)

By: josh

josh — Wed, 19 Nov 2008 04:34:23 +0000

@demetris: Patches accepted. Send me the .png! ;-)

@Otto: Handy tip, and answers demetris’ question too. By default themes will load the comment script regardless of the wp-admin setting; but it’s easy enough to check for it with a conditional. Thanks for the comment!

Like many things WordPress, I like this feature. I just like it better in a plugin — of which there were already several.

By: Otto

Otto — Tue, 18 Nov 2008 21:57:56 +0000

If you want it to not load the javascript unless threading is turned on the the admin interface, use this code in the header.php:

if ( get_option('thread_comments') && is_singular() ) wp_enqueue_script( 'comment-reply' );

That will make it only load the comment javascript when threading is turned on AND you’re on the single post pages.